EIP-7251: Rename get_churn_limit() for clarity#3676
Merged
Conversation
fradamt
approved these changes
Apr 16, 2024
ralexstokes
approved these changes
Apr 16, 2024
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
makes sense!
note: not substantive, just changing the name and this function is not currently directly tested in the specs (instead we test wrapping helpers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have
get_validator_churn_limit()so this change will mean we have:get_balance_churn_limitget_validator_churn_limitThis way the names reflect the difference between them (one returns the churn limit in units of 32 ETH validators and the other returns the churn limit in terms of ETH).