EIP-7251: misc changes#3636
Merged
Merged
Conversation
This reverts commit 6f5cc4b.
Member
|
I haven't gone through the changes, but the summary sounds good from a high-level |
fradamt
reviewed
Apr 4, 2024
|
|
||
| return | ||
|
|
||
| has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE |
Contributor
There was a problem hiding this comment.
Suggested change
| has_sufficient_effective_balance = validator.effective_balance == MIN_ACTIVATION_BALANCE | |
| has_sufficient_effective_balance = validator.effective_balance >= MIN_ACTIVATION_BALANCE |
Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>
ralexstokes
approved these changes
Apr 6, 2024
Member
ralexstokes
left a comment
There was a problem hiding this comment.
looks good! I lean towards merging (and ill make an issue for one comment l left, either I don't understand how the new partial withdrawals work or there is a bug...) and then ill make a testing pass in #3648
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
set_compounding_withdrawal_credentialsas it is unusedFULL_EXIT_REQUEST_AMOUNTwhich is set to0validator.effective_balance == MIN_ACTIVATION_BALANCEcheck to partial withdrawalsThis check is borrowed from the sweep checks. Although, satisfying this condition with partial withdrawal is not as critical as with the sweep, re-gaining the min activation balance sooner should be aligned with interest of stakers and network
process_execution_layer_withdraw_requestvalidator.effective_balancefor consolidation churn to align its logic with the exit churn and with the churn limit computation which is EB basedprocess_execution_layer_withdraw_requestflow