Skip to content

Init Electra (EIP6110 + EIP7002) - #3615

Merged
hwwhww merged 8 commits into
devfrom
init-electra
Apr 9, 2024
Merged

hwwhww merged 8 commits into
devfrom
init-electra

Conversation

@hwwhww

@hwwhww hwwhww commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Merged EIP6110 and EIP7002 specs into new Electra specs.

/cc @djrtwo


#### `DepositReceipt`

*Note*: The container is new in EIP6110.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note can be inferred from

 deposit_receipts: List[DepositReceipt, MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD]  # [New in Electra:EIP6110]`

not sure if it's worth the percent and now we may have to annotate all containers

@mkalinin mkalinin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a couple of nits!

fork.md still refers to EIP-6110: "This document describes the process of EIP-6110 upgrade.” (couldn’t make a proper link to this line)

Comment thread specs/electra/beacon-chain.md Outdated

@djrtwo djrtwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@StefanBratanov

Copy link
Copy Markdown
Contributor

I raised a small PR #3629 for an EIP-6110 function rename. I am not sure if a comment here would have been more appropriate.

@hwwhww hwwhww mentioned this pull request Mar 26, 2024

@lucassaldanha lucassaldanha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@hwwhww
hwwhww marked this pull request as ready for review April 4, 2024 22:11
Comment thread presets/mainnet/electra.yaml Outdated
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
@hwwhww
hwwhww merged commit aba6345 into dev Apr 9, 2024
@hwwhww
hwwhww deleted the init-electra branch April 9, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants