Init Electra (EIP6110 + EIP7002) - #3615
Merged
Merged
Conversation
dapplion
reviewed
Mar 11, 2024
|
|
||
| #### `DepositReceipt` | ||
|
|
||
| *Note*: The container is new in EIP6110. |
Member
There was a problem hiding this comment.
This note can be inferred from
deposit_receipts: List[DepositReceipt, MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD] # [New in Electra:EIP6110]`
not sure if it's worth the percent and now we may have to annotate all containers
khademreza5
approved these changes
Mar 11, 2024
mkalinin
reviewed
Mar 18, 2024
mkalinin
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me except for a couple of nits!
fork.md still refers to EIP-6110: "This document describes the process of EIP-6110 upgrade.” (couldn’t make a proper link to this line)
This was referenced Mar 19, 2024
Contributor
|
I raised a small PR #3629 for an |
Merged
hwwhww
marked this pull request as ready for review
April 4, 2024 22:11
hwwhww
commented
Apr 4, 2024
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged EIP6110 and EIP7002 specs into new Electra specs.
/cc @djrtwo