Add transition test case of non-empty pre-state historical_roots
#3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
approved these changes
Jan 17, 2024
| Therefore, we need to fill in `historical_roots` with non-empty value. | ||
| """ | ||
| # fill in historical_roots with non-empty values | ||
| pre_historical_roots = [b'\x56' * 32 for _ in range(spec.SLOTS_PER_HISTORICAL_ROOT)] |
There was a problem hiding this comment.
SLOTS_PER_HISTORICAL_ROOT is fine here but it's a bit misleading in it's relationship to historical_roots which is a list of unbound length
There was a problem hiding this comment.
The test would do its job with > 0 items so why no set it to 1?
dapplion
reviewed
Jan 18, 2024
tests/core/pyspec/eth2spec/test/altair/transition/test_transition.py
Outdated
Show resolved
Hide resolved
| Therefore, we need to fill in `historical_roots` with non-empty value. | ||
| """ | ||
| # fill in historical_roots with non-empty values | ||
| pre_historical_roots = [b'\x56' * 32 for _ in range(spec.SLOTS_PER_HISTORICAL_ROOT)] |
There was a problem hiding this comment.
The test would do its job with > 0 items so why no set it to 1?
hwwhww
commented
Jan 18, 2024
tests/core/pyspec/eth2spec/test/altair/transition/test_transition.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Lion - dapplion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
To cover prysmaticlabs/prysm#13477 with this test case.
Description
historical_roots