Optimization: reduce len() calls in add_polynomialcoeff#3581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I made some profiles on the DAS test case
test_verify_cell_proof, which includes acompute_cells_and_proofscall and twoverify_cell_proofcalls. It turns outlen()is somewhat expensive if we call it 400M times.For the sake of tidiness and readability, We intentionally didn't have such optimization in spec writing. However, this one seems gain great performance improvement with only two extra lines.
Before
After reducing the
len()calls inadd_polynomialcoeffThis minor optimization here use temporary variables to keep the
len(a)andlen(b)results:It reduced ~35% time of this case.