Align gossip validation for aggregates with single attestations #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple gossip validation rules are only specced out for single un-aggregated attestations, but are also checked by implementations for aggregates. This adds a copy of the missing gossip validation rules to the aggregated attestation docs.
etan-status
commented
Nov 22, 2023
| - _[IGNORE]_ `aggregate.data.slot` is within the last `ATTESTATION_PROPAGATION_SLOT_RANGE` slots (with a `MAXIMUM_GOSSIP_CLOCK_DISPARITY` allowance) -- | ||
| i.e. `aggregate.data.slot + ATTESTATION_PROPAGATION_SLOT_RANGE >= current_slot >= aggregate.data.slot` | ||
| (a client MAY queue future aggregates for processing at the appropriate slot). | ||
| - _[REJECT]_ The aggregate attestation's epoch matches its target -- i.e. `aggregate.data.target.epoch == | ||
| compute_epoch_at_slot(aggregate.data.slot)` | ||
| - _[REJECT]_ The number of aggregation bits matches the committee size -- i.e. |
There was a problem hiding this comment.
This is not the number of 1 bits, but the total number of bits regardless of value. Same condition as for the single attestations.
|
Looks good to me. Thanks. |
ppopth
approved these changes
Nov 22, 2023
rolfyone
reviewed
Nov 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple gossip validation rules are only specced out for single un-aggregated attestations, but are also checked by implementations for aggregates. This adds a copy of the missing gossip validation rules to the aggregated attestation docs.