Skip to content

fix(sepcs/p2p): link to libp2p Yamux specification#3493

Merged
hwwhww merged 1 commit intoethereum:devfrom
mxinden:patch-1
Sep 15, 2023
Merged

fix(sepcs/p2p): link to libp2p Yamux specification#3493
hwwhww merged 1 commit intoethereum:devfrom
mxinden:patch-1

Conversation

@mxinden
Copy link
Contributor

@mxinden mxinden commented Sep 4, 2023

Previously the specification would link to the Hashicorp Yamux specification.

https://github.com/hashicorp/yamux/blob/master/spec.md

Since adoption by libp2p, there have been multiple refinements to the original specification. The improved specification can be found in the libp2p specification repository.

https://github.com/libp2p/specs/blob/master/yamux/README.md

//CC @AgeManning and @jxs

Copy link
Member

@haxxpop haxxpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dapplion
Copy link
Member

@mxinden can you rebase your PR on latest dev? CI is failing and needs the fix from #3495

Previously the specification would link to the Hashicorp Yamux specification.

https://github.com/hashicorp/yamux/blob/master/spec.md

Since adoption by libp2p, there have been multiple refinements to the original specification. The improved specification can be found in the libp2p specification repository.

https://github.com/libp2p/specs/blob/master/yamux/README.md
@mxinden
Copy link
Contributor Author

mxinden commented Sep 14, 2023

@dapplion done. Mind taking another look?

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mxinden!

@hwwhww hwwhww merged commit d26dac9 into ethereum:dev Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants