Whisk: Move non-preset values to config#3482
Merged
asn-d6 merged 1 commit intoethereum:devfrom Aug 20, 2023
Merged
Conversation
asn-d6
approved these changes
Aug 20, 2023
Contributor
|
Thanks! |
Contributor
|
Also need to update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preset values should be those that affect types or other build time data structures.
Both
WHISK_EPOCHS_PER_SHUFFLING_PHASEandWHISK_PROPOSER_SELECTION_GAPdo not affect any data structure and are useful to tweak in tests to speed up their runtime. SettingWHISK_PROPOSER_SELECTION_GAPto a value>= WHISK_EPOCHS_PER_SHUFFLING_PHASE - 1disables tracker shuffling