[wip] testgen reproducibility with MODE_MULTIPROCESSING mode
#3479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release v1.4.0-alpha.1
release v1.4.0-alpha.2
release 1.4.0-alpha.3
release v1.4.0-beta.0
release v1.4.0-beta.1
…in the stateful for-loop
Member
|
I am closing this issue because it seems stale. Please, do not hesitate to reopen it if this is a mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3473 fix, we can try to turn on the
MODE_MULTIPROCESSINGmode.However, we have some randomized tests that are not using deterministic seed in multiprocessing mode. The tests should be updated to reproducible with
MODE_MULTIPROCESSINGmode.I'm checking the diff case by case, against
v1.4.0-beta.1:https://gist.githubusercontent.com/hwwhww/9a5b4eecf34f756437c4f3f5a327ff3a/raw/d5bc62e2645f8e3f8ed07f6bcc198c89989aa678/multiprocessing_diff.txt
NOTE: to other reviewers, please don't rebase/merge this branch to the
devbranch since I'm verifying against themasterbranch.TODO:
ssz_statictestswithdrawaltestson_mergetestsrandomtestsinitializationtests (due to deposit testing helpers)sanity/blocks/pyspec_tests/one_blob_two_txskzgtestsblstests