Move and rework include_attestation_from_previous_fork_with_new_range test to a transition test#3464
Merged
Move and rework include_attestation_from_previous_fork_with_new_range test to a transition test#3464
include_attestation_from_previous_fork_with_new_range test to a transition test#3464Conversation
This was referenced Jul 27, 2023
Merged
djrtwo
approved these changes
Jul 27, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
looks good! apologies for putting it in a weird spot with an incorrect/weird decorator
…e` test to a `transition` test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address ethereum/consensus-spec-tests#35
Thank @ethDreamer for reporting it.
It's simpler to move this test case to
transitiontests instead of trying to make it stay insanityblock tests. The transition test case format has defined thefork_epochso we don't need to applyspec_configured_state_testdecorator and override the config there.