Skip to content

Deneb: Add test cases to execution payload processing#3459

Merged
djrtwo merged 2 commits intoethereum:devfrom
marioevz:deneb-test-cases-comments
Jul 19, 2023
Merged

Deneb: Add test cases to execution payload processing#3459
djrtwo merged 2 commits intoethereum:devfrom
marioevz:deneb-test-cases-comments

Conversation

@marioevz
Copy link
Member

Adds a couple of simple test cases I thought could be interesting.

I added a small comment of my understanding of the goal of the tests in this file, and based on that is what I thought was missing and added, but if this was a misinterpretation please let me know.

I'll try to think of more tests to add.

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marioevz thank you! 🚀


@with_deneb_and_later
@spec_state_test
def test_no_transactions_with_commitments(spec, state):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a good test case! 👍

@hwwhww hwwhww added the testing CI, actions, tests, testing infra label Jul 19, 2023
@hwwhww hwwhww mentioned this pull request Jul 19, 2023
7 tasks
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in @marioevz!

Things look good. @hwwhww will you add to the running spreadsheet?

@djrtwo djrtwo merged commit ff2840e into ethereum:dev Jul 19, 2023
@hwwhww
Copy link
Contributor

hwwhww commented Jul 20, 2023

@djrtwo done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants