More deneb tests #3457
Merged
More deneb tests #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Jul 18, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
very nice! just a couple of nits
| blob_kzg_commitments += commits | ||
|
|
||
| for _ in range(non_blob_tx_count): | ||
| txs.append(get_random_tx(rng=rng)) |
Contributor
There was a problem hiding this comment.
Maybe should use rng to shuffle the txs list before applying to the el payload
| num_transactions = rng.randint(0, 100) | ||
| execution_payload.transactions = [ | ||
| spec.Transaction(get_random_bytes_list(rng, rng.randint(0, 1000))) | ||
| get_random_tx(rng) |
Contributor
There was a problem hiding this comment.
This helper should probably condition on is_post_bellatrix (or whatever the appropriate helper is) to toss in some random blob TXs in Deneb and after
Contributor
Author
There was a problem hiding this comment.
hmm I thought about it, but it would need build_randomized_execution_payload to return blob_kzg_commitments, which is not well-compatible and clean with pre-deneb.
djrtwo
approved these changes
Jul 19, 2023
Contributor
|
ready to merge when you are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_randomized_execution_payloadhelper inrandomtestsblob_count