Skip to content

Conversation

@jtraglia
Copy link
Member

@jtraglia jtraglia commented Jul 15, 2023

  • Fix links to curdleproofs.pie repository.
    • The verifier-only branch no longer exists.
  • Remove "modified in whisk" comment from validators field.
    • This is no longer modified.
  • Fix minor typo in sentence (a comma should be a period).

Also, I'm not quite sure which branch to use in the cuddleproof.pie links. I think dev is the closest, but the IsValidWhiskShuffleProof definition here is missing the crs parameter. Maybe something to fix in a separate PR.

@jtraglia jtraglia changed the title Fix links to curdleproofs.pie repo Fix some nits in whisk spec Jul 15, 2023
Copy link
Member

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hwwhww hwwhww merged commit e2cf91d into ethereum:dev Jul 24, 2023
@jtraglia jtraglia deleted the fix-links branch July 24, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants