Auto manage SpecBuilder prev fork inheritance#3436
Merged
hwwhww merged 2 commits intoethereum:devfrom Jun 26, 2023
Merged
Conversation
dapplion
commented
Jun 20, 2023
| return spec | ||
| ssz_dep_constants_verification, | ||
| ] | ||
| return "\n\n\n".join([str.strip("\n") for str in spec_strs if str]) + "\n" |
Member
Author
There was a problem hiding this comment.
Because of the automated nature of computing the spec parts, I needed a way to ensure a constant 2 blank lines separation between each section
hwwhww
approved these changes
Jun 21, 2023
| return spec | ||
| ssz_dep_constants_verification, | ||
| ] | ||
| return "\n\n\n".join([str.strip("\n") for str in spec_strs if str]) + "\n" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
PREVIOUS_FORK_OFto FORK_B, but then inheriting from the SpecBuilder of FORK_C downstream issues that are hard to debug except for experienced mantainers.This PR reduces a potential footgun by computing the inheritance of SpecBuilder objects automatically from the fork relationships specified in
PREVIOUS_FORK_OF