Conversation
ralexstokes
force-pushed
the
4788-in-deneb
branch
16 times, most recently
from
02a40f3 to
daa581b
Compare
ralexstokes
commented
Jun 13, 2023
ralexstokes
commented
Jun 13, 2023
ralexstokes
commented
Jun 13, 2023
ralexstokes
commented
Jun 13, 2023
hwwhww
reviewed
Jun 13, 2023
Contributor
hwwhww
left a comment
hwwhww
left a comment
There was a problem hiding this comment.
Great work!
Need to initialize the state.latest_execution_payload_header.parent_beacon_block_root value in specs/deneb/fork.md::upgrade_to_deneb helper.
The rest changes look good to me. 👍
tests/core/pyspec/eth2spec/test/deneb/block_processing/test_process_execution_payload.py
Outdated
Show resolved
Hide resolved
This was referenced Jun 13, 2023
mkalinin
reviewed
Jun 14, 2023
djrtwo
reviewed
Jun 14, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
Looks good. I think we can/should get rid of the helper noted below
ralexstokes
force-pushed
the
4788-in-deneb
branch
from
dccb913 to
fec9f8e
Compare
ralexstokes
force-pushed
the
4788-in-deneb
branch
11 times, most recently
from
051ae2f to
3707ef9
Compare
ralexstokes
force-pushed
the
4788-in-deneb
branch
from
3707ef9 to
2660af0
Compare
djrtwo
approved these changes
Jun 22, 2023
3 tasks
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 29, 2023
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 29, 2023
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 30, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrates EIP-4788 spec from an experimental feature to part of
Deneb