[KZG] Serialize roots of unity as hex as well#3357
Closed
mratsim wants to merge 3 commits intoethereum:devfrom
mratsim:kzg-roots-hex
Closed
[KZG] Serialize roots of unity as hex as well#3357mratsim wants to merge 3 commits intoethereum:devfrom mratsim:kzg-roots-hex
mratsim wants to merge 3 commits intoethereum:devfrom
mratsim:kzg-roots-hex
Conversation
Contributor
In CL specs, we use SSZ to define ^^^ However, it may be messier per #3354. 🫨 |
Contributor
|
I agree with @mratsim that these should be hex-encoded. On top of that, I'm not convinced these should be a JSON file either. As was discussed at Edelweiss, most crypto libraries won't have a JSON parser, so it seems prudent to have an even flatter (text) file. |
Contributor
|
closing via #3521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This serializes the roots_of_unity as hex as well.
Most JSON readers would fail to deserialize a bigint encoded as int and while most cryptographic libraries have a hex->internal_repr converter, many don't have a decimal->internal_repr converter, in particular BLST.