Check correct fork version in LC sync protocol #3284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sync committee is determined by signature_slot - Signature fork version is determined by max(signature_slot, 1) - 1 - Attested block fork version can be anything < signature_slot Old logic incorrectly derived signature fork version from signature_slot and did not subtract a slot. Extended tests to check this edge case.
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Mar 8, 2023
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Mar 8, 2023
EmilIvanichkovv
added a commit
to metacraft-labs/DendrETH
that referenced
this pull request
Mar 9, 2023
Fixes a LC bug found by the Nimbus team. Related PRs: - status-im/nimbus-eth2#4703 - ethereum/consensus-specs#3284
zah
pushed a commit
to metacraft-labs/DendrETH
that referenced
this pull request
Mar 9, 2023
Fixes a LC bug found by the Nimbus team. Related PRs: - status-im/nimbus-eth2#4703 - ethereum/consensus-specs#3284
dapplion
approved these changes
Mar 9, 2023
Member
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
Nice pick, Lodestar is affected by the bug
hwwhww
approved these changes
Mar 15, 2023
Contributor
hwwhww
left a comment
hwwhww
left a comment
There was a problem hiding this comment.
lgtm
this light client fork version thing is so unfortunately so tricky
bluele
added a commit
to datachainlab/ethereum-light-client-rs
that referenced
this pull request
Oct 27, 2024
Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
bluele
added a commit
to datachainlab/ethereum-light-client-rs
that referenced
this pull request
Oct 27, 2024
Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
block-druidxrew3
added a commit
to block-druidxrew3/DendrETH
that referenced
this pull request
Oct 27, 2025
Fixes a LC bug found by the Nimbus team. Related PRs: - status-im/nimbus-eth2#4703 - ethereum/consensus-specs#3284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old logic incorrectly derived signature fork version from signature_slot and did not subtract a slot. Extended tests to check this edge case.