Skip to content

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Feb 24, 2023

Description

Currently the polynomial-commitments file relies on py-ecc types and methods. This can be seen with the usage of bls.Z1 and bls.G1. If we do plan to use another library, removing this decoupling is a necessary pre-requisite.

Changes

  • Removed Z2 and FQ from imports in bls.py as they were not being used
  • aliased all py_ecc direct imports that we need for 4844 with a py_ecc prefix
  • Added wrapper methods which for now directly call py_ecc, but in the future can conditionally call a different library

Note

I have intentionally not tried to change method names, so the changes in polynomial-commitments are easy to grep.


EDIT:

  • Dankrad has also added in the py-arkworks library into this PR.

@kevaundray kevaundray force-pushed the kw/py-ecc-agnostic-4844 branch from cbeb7cf to f59dd7c Compare February 24, 2023 17:56
@dankrad dankrad force-pushed the kw/py-ecc-agnostic-4844 branch from df9167f to dbfb1ac Compare February 25, 2023 22:26
@kevaundray kevaundray changed the title EIP4844: Remove reliance on py-ecc types in polynomial-commitments EIP4844: Remove reliance on py-ecc types in polynomial-commitments and add py-arkworks Feb 26, 2023
@hwwhww
Copy link
Contributor

hwwhww commented Feb 28, 2023

((Moving arkworks discussion to this PR))

Hey @kevaundray, I just realized my PyPy3.9 was built with 0.3.2 because 0.3.3 doesn't provide "Source Distributions" on PyPi. Could you upload the source distributions for 0.3.3?

image

Also, for completeness, it would be nice to upload macos Python3.9 distributions too. 🙏

@hwwhww hwwhww added the testing CI, actions, tests label Feb 28, 2023
@kevaundray
Copy link
Contributor Author

((Moving arkworks discussion to this PR))

Hey @kevaundray, I just realized my PyPy3.9 was built with 0.3.2 because 0.3.3 doesn't provide "Source Distributions" on PyPi. Could you upload the source distributions for 0.3.3?

image

Also, for completeness, it would be nice to upload macos Python3.9 distributions too. 🙏

@hwwhww I've added 3.8 to 3.11 along with source distributions in version 0.3.4, please let me know if anything else is missing :)

@kevaundray
Copy link
Contributor Author

Closing as this was merged into #3274 which was merged into dev yesterday

@kevaundray kevaundray closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants