EIP4844: All public methods take bytes as input (also added explicit G1 validation) #3224
Conversation
asn-d6
force-pushed
the
eip4844_group_bytes
branch
from
4ef23fa to
a4fdff3
Compare
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Looking good, I have some minor nits.
|
Points to discuss tomorrow:
|
| validate_kzg_g1(commitment) | ||
| validate_kzg_g1(proof) | ||
|
|
||
| return verify_kzg_proof_impl(commitment, |
There was a problem hiding this comment.
This needs to be cast explicitly to match the expected types of _impl
There was a problem hiding this comment.
Pushed 4204f4c which introduces explicit type conversion between "untrusted" bytes and "trusted" BLS types.
| expected_kzg_commitments: Sequence[KZGCommitment], | ||
| kzg_aggregated_proof: KZGProof) -> bool: | ||
| expected_kzg_commitments_bytes: Sequence[Bytes48], | ||
| kzg_aggregated_proof_bytes: Bytes48) -> bool: |
There was a problem hiding this comment.
For consistency, could we rename these to expected_commitments_bytes & aggregated_proof_bytes, respectively?
|
|
||
| ```python | ||
| def verify_kzg_proof_impl(polynomial_kzg: KZGCommitment, | ||
| def verify_kzg_proof_impl(commitment: KZGCommitment, |
There was a problem hiding this comment.
Also, maybe rename this to expected_commitment for consistency?
There was a problem hiding this comment.
Did the opposite -- as discussed -- in 3db5654
| def verify_kzg_proof(polynomial_kzg: KZGCommitment, | ||
| def verify_kzg_proof(commitment_bytes: Bytes48, | ||
| z: Bytes32, | ||
| y: Bytes32, |
There was a problem hiding this comment.
Shouldn't z and y be z_bytes and y_bytes?
There was a problem hiding this comment.
We decided to do this rename in the future.
asn-d6
force-pushed
the
eip4844_group_bytes
branch
from
3db5654 to
03ff210
Compare
6 participants
This is the next step after #3219 . With this patch all Public methods take bytes as input and do explicit validation (that is, the G1 group validation specified by #3223).
We introduce a new validation function called
validate_kzg_g1()which implements the validation rules forKZGCommitmentandKZGProof. We now do the validation in an explicit manner.After this patch,
KZGCommitmentandKZGProofnow represent G1 byte arrays that have been validated. They should only be used by internal functions.