eip4844: move excess data gas field to end of execution payload for merkle proof path compat#3218
Merged
djrtwo merged 4 commits intoethereum:devfrom Feb 14, 2023
Merged
Conversation
dapplion
approved these changes
Jan 24, 2023
arnetheduck
approved these changes
Jan 24, 2023
ralexstokes
approved these changes
Jan 24, 2023
Contributor
Author
|
This change does not apply yet to the interop week devnet |
djrtwo
approved these changes
Jan 24, 2023
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
approving
will merge at end of week in case we need to do an iterative 4844 release (of some other fix) between now and then
Contributor
|
[DO NOT MERGE] The CI is failing: it needs a |
hwwhww
force-pushed
the
excess-data-gas-field-position
branch
from
ba0947a to
7b5acbf
Compare
Contributor
|
@djrtwo is it ready to merge? |
hwwhww
approved these changes
Feb 10, 2023
Contributor
|
I think we should make this a general recommendation / requirement: only add fields at the end of existing types |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the other fields in the same position, to avoid merkle-proof format changes