Conversation
| def description(case_description: str): | ||
| def entry(fn): | ||
| return with_meta_tags({'description': case_description})(fn) | ||
| return entry |
There was a problem hiding this comment.
This is not in use in this PR, but it can be utilized to add notes to the test vector results in future PRs.
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
wow this is amazing! nice work :)
I left a few comments but generally looks very good, thanks for doing this!
| _new_altair_mods = { | ||
| **{'sync_aggregate': [ | ||
| 'eth2spec.test.altair.block_processing.sync_aggregate.test_process_' + key | ||
| for key in ['sync_aggregate', 'sync_aggregate_random'] | ||
| ]}, | ||
| **{key: 'eth2spec.test.altair.block_processing.test_process_' + key for key in [ | ||
| 'deposit', | ||
| ]} | ||
| } |
There was a problem hiding this comment.
this is outside the scope of this PR but it would be very nice to have some kind of linter that would take the spec and test code and ensure we didn't miss anything...
There was a problem hiding this comment.
Indeed. 😭
And it would be nice to auto-generate the mods or with more clever settings.
tests/core/pyspec/eth2spec/test/phase0/block_processing/test_process_deposit.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/bellatrix/block_processing/test_process_deposit.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/bellatrix/block_processing/test_process_deposit.py
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_deposit.py
Outdated
Show resolved
Hide resolved
| @with_altair_and_later | ||
| @spec_state_test | ||
| @always_bls | ||
| def test_ineffective_deposit_with_bad_fork_version_and(spec, state): |
There was a problem hiding this comment.
test_ineffective_deposit_with_bad_fork_version_and
... and what? :)
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_deposit.py
Show resolved
Hide resolved
| ) | ||
|
|
||
|
|
||
| @with_phases([ALTAIR]) |
There was a problem hiding this comment.
can this be "altair and later"?
There was a problem hiding this comment.
No, this is the control group of bellatrix/block_processing/test_process_deposit.py::test_ineffective_deposit_with_previous_fork_version. Altair's previous fork is exactly the correct GENESIS_FORK_VERSION while others' are not.
Added more comments (34907d2) and current_fork_version test case (e5709a5).
hwwhww
force-pushed
the
test-cases-clean-up
branch
from
d11189b to
338806d
Compare
…est_ineffective_deposit_with_bad_fork_version`
|
@ralexstokes thanks for the reviews! 😊 |
3 participants
Address #3118
descriptionspec test decoratorprocess_deposittests