Skip to content

Fix docstring for compute_powers and compute_challenges methods #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asn-d6 merged 2 commits into from
Nov 24, 2022
Merged

Fix docstring for compute_powers and compute_challenges methods #3130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b3d185
Fix docstring
kevaundray Nov 23, 2022
63859d1
fix: add fullstop
kevaundray Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specs/eip4844/polynomial-commitments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def compute_challenges(polynomials: Sequence[Polynomial],

hashed_data = hash(DOMAIN_SEPARATOR, polynomials, commitments)
r = hash(hashed_data, 0)
r_powers = [r, r**2, r**3, ...]
r_powers = [1, r, r**2, r**3, ...]
eval_challenge = hash(hashed_data, 1)

Then return `r_powers` and `eval_challenge` after converting them to BLS field elements.
Expand Down Expand Up @@ -259,7 +259,7 @@ def poly_lincomb(polys: Sequence[Polynomial],
```python
def compute_powers(x: BLSFieldElement, n: uint64) -> Sequence[BLSFieldElement]:
"""
Return ``x`` to power of [0, n-1].
Return ``x`` to power of [0, n-1], if n > 0. When n==0, an empty array is returned.
"""
current_power = 1
powers = []
Expand Down