Fix latest_execution_payload_header field in eip4844 state upgrade
#3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
changed the title
tbenr
changed the title
latest_execution_payload_header field in eip4844 state upgrade
ralexstokes
reviewed
Nov 16, 2022
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
nice catch!
#3044 is related
Co-authored-by: Alex Stokes <[email protected]>
Contributor
Author
|
since #3052 is not yet merged, I was proposing a change to the current version, and let the rebase change the header here accordingly. |
Co-authored-by: Alex Stokes <[email protected]>
hwwhww
approved these changes
Nov 17, 2022
Contributor
hwwhww
left a comment
hwwhww
left a comment
There was a problem hiding this comment.
Thanks @tbenr!
I merged @ralexstokes's suggestions and think we can go merge this PR first.
note: also related to #3004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think latest_execution_payload_header upgrade has been forgotten