clarify deprecation of beacon_block gossip topic in 4844
#3090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! 🙏🏼 |
|
This looks good to me! |
djrtwo
reviewed
Nov 9, 2022
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
Let's make it clear when to disable the topic
Co-authored-by: Danny Ryan <[email protected]>
ralexstokes
force-pushed
the
4844-topic-dep
branch
from
a60b105 to
38669d4
Compare
Member
Author
|
I think this is ready to go, just needs an approving review |
2 tasks
djrtwo
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3088