Rename LC test check from root to beacon_root#3067
Merged
ralexstokes merged 1 commit intoethereum:devfrom Oct 28, 2022
Merged
Conversation
Future light client tests will also incorporate execution payload data. To avoid confusion, rename the current `root` check to `beacon_root`. Doing this now, as ethereum#3066 already requires LC test runners to update.
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 9, 2022
`root` member was renamed to `beacon_root` as part of ethereum/consensus-specs#3067
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 9, 2022
`root` member was renamed to `beacon_root` as part of ethereum/consensus-specs#3067
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 18, 2022
`state.ssz_snappy` file was renamed to `object.ssz_snappy` and `pyspec_tests` folder was renamed to `BeaconState` as part of ethereum/consensus-specs#3067
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future light client tests will also incorporate execution payload data. To avoid confusion, rename the current
rootcheck tobeacon_root. Doing this now, as #3066 already requires LC test runners to update.