Skip to content

EIP4844: various fixes #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djrtwo merged 3 commits into from
Sep 30, 2022
Merged

EIP4844: various fixes #3019

djrtwo merged 3 commits into from
Sep 30, 2022

Conversation

@terencechain
Copy link
Contributor

@terencechain terencechain commented Sep 29, 2022

  • Add unit epoch to MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS
  • The current backfill blob validation is incorrect. It looks like it was copy-pasted from backfill block validation. I removed it. It might be worth considering what backfill validation we want for the blob. To validate the signature, we need to change BlobsSidecarsByRange to SignedBlobsSidecarsByRange. It may be worth checking that blobs are canonical by cross-referencing with the local fork choice view
  • Validator broadcasts signed_beacon_block, not beacon_block

dapplion
dapplion reviewed Sep 29, 2022
View reviewed changes
@hwwhww hwwhww added the deneb label Sep 30, 2022
@djrtwo djrtwo merged commit 6b9e65f into ethereum:dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dapplion dapplion dapplion left review comments

@djrtwo djrtwo djrtwo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deneb

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terencechain @djrtwo @dapplion @hwwhww