Skip to content

Conversation

@hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Sep 28, 2022

  1. Bump dependencies
    • Update most dependencies to the latest version
    • Remove dataclasses dep because it's built-in in Python 3.7+
    • Somehow, marko==1.2.2 is not backward compatible so I didn't update it
  2. Fix the lint issues found by the newer linter
    • E741 ambiguous variable name 'l' in bit_reversal_permutation:
      • I renamed l to sequence. /cc @asn-d6
    • F541 f-string is missing placeholders:
      • I cleaned up the strings
    • from_bytes has incompatible type "str"; expected "Literal['little', 'big']":

@hwwhww hwwhww added the testing CI, actions, tests, testing infra label Sep 28, 2022
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed l to sequence. /cc @asn-d6 change LGTM! (Haven't looked at the non-4844 changes though)

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes all look good and if the CI passes them I'll assume all of the newer deps don't break anything

+1 on merge

@hwwhww hwwhww merged commit 3552e2f into dev Oct 6, 2022
@hwwhww hwwhww deleted the bump-dep branch October 6, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants