deprecate phase 0-only versions of beacon_blocks_by_{range,root}#3014
Merged
hwwhww merged 1 commit intoethereum:devfrom Nov 29, 2022
tersec:deprecate-phase0-beacon-blocks-req-resp
Merged
deprecate phase 0-only versions of beacon_blocks_by_{range,root}#3014hwwhww merged 1 commit intoethereum:devfrom tersec:deprecate-phase0-beacon-blocks-req-resp
hwwhww merged 1 commit intoethereum:devfrom
tersec:deprecate-phase0-beacon-blocks-req-resp
Conversation
djrtwo
approved these changes
Sep 26, 2022
Contributor
djrtwo
left a comment
djrtwo
left a comment
There was a problem hiding this comment.
looks reasonable to me.
will leave this open for a week for comment
nisdas
approved these changes
Sep 27, 2022
Contributor
nisdas
left a comment
nisdas
left a comment
There was a problem hiding this comment.
LGTM, should we also apply the same principle to v1 metadata requests ? They are deprecated and all clients should support v2 from altair onwards.
etan-status
approved these changes
Oct 3, 2022
dapplion
approved these changes
Oct 3, 2022
arnetheduck
approved these changes
Nov 3, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There haven't been any phase0 blocks in mainnet or any of the still-supported testnets in
MIN_EPOCHS_FOR_BLOCK_REQUESTSregardless, so the spec already technically supports not serving said blocks.https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/p2p-interface.md#beaconblocksbyrange-v2 and https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/p2p-interface.md#beaconblocksbyroot-v2 work across all supported forks, including phase 0, and any CL client supporting Altair or newer already has to support those messages, so this maintains req/resp compatibility for phase 0 blocks.