Skip to content

Conversation

@Inphi
Copy link
Contributor

@Inphi Inphi commented Jun 13, 2022

We no longer need the placeholder shard field in the BlobsSidecar because with danksharding we'll most likely use a transaction-index, rather than index blobs by a shard.

@Inphi
Copy link
Contributor Author

Inphi commented Jun 13, 2022

cc: @protolambda

@protolambda
Copy link
Contributor

In 45e207b the shard field was already removed, and this occurrence in the validator doc was forgotten. Nice catch

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asn-d6
Copy link
Contributor

asn-d6 commented Jun 14, 2022

LGTM

@protolambda protolambda merged commit 3dbbeb9 into ethereum:dev Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants