Skip to content

bump milagro bls binding version - #2893

Merged
ralexstokes merged 1 commit into
ethereum:devfrom
ChihChengLiang:bump-milagro-version
May 14, 2022
Merged

bump milagro bls binding version#2893
ralexstokes merged 1 commit into
ethereum:devfrom
ChihChengLiang:bump-milagro-version

Conversation

@ChihChengLiang

Copy link
Copy Markdown
Contributor

The new version of milagro bls binding supports py3.10(#2780) and arm (#2886).

@ralexstokes ralexstokes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ralexstokes
ralexstokes merged commit 30a3326 into ethereum:dev May 14, 2022
@ralexstokes

Copy link
Copy Markdown
Member

@ChihChengLiang do you have any thoughts on ensuring there aren't any regressions across different versions of this software?

@ChihChengLiang

Copy link
Copy Markdown
Contributor Author

@ralexstokes I think the regression is unlikely due to these reasons:

  1. The binding itself is covered in the same set of tests, which haven't changed during this upgrade.
  2. No significant updates in the upstream of the binding affect the codebase of binding and the spec.
  3. All spec tests that consume the binding passed.

@ralexstokes

Copy link
Copy Markdown
Member

the concern would be consistency across versions of the software but I agree it is unlikely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants