Allow light client updates to only improve optimistic header#2811
Closed
etan-status wants to merge 1 commit intoethereum:devfrom
etan-status:lc-opt-update
Closed
Allow light client updates to only improve optimistic header#2811etan-status wants to merge 1 commit intoethereum:devfrom etan-status:lc-opt-update
etan-status wants to merge 1 commit intoethereum:devfrom
etan-status:lc-opt-update
Conversation
The current `LightClientUpdate` logic rejects updates not advancing the best known `finalized_header`, even when the `optimistic_header` could be advanced. This patch changes the logic to also process updates that solely advance the `optimistic_header`.
Contributor
Author
|
This PR will not be needed anymore, as this will be a side effect of removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
LightClientUpdatelogic rejects updates not advancing thebest known
finalized_header, even when theoptimistic_headercouldbe advanced. This patch changes the logic to also process updates that
solely advance the
optimistic_header.