fix: node.js publish #502
Merged
fix: node.js publish #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkeil
commented
Aug 26, 2024
matthewkeil
commented
Aug 26, 2024
| @@ -1,10 +1,10 @@ | |||
| { | |||
| "name": "c-kzg", | |||
| "version": "4.0.0", | |||
| "version": "4.0.1", | |||
There was a problem hiding this comment.
Found the issue after running the publish command with 4.0.0 so needed to bump the minor. Not sure why this showed up now though.
matthewkeil
commented
Aug 26, 2024
Comment on lines
-47
to
-56
| # Bundle the distribution, also helpful for cross compatibility checks | ||
| .PHONY: bundle | ||
| bundle: build | ||
| @mkdir dist | ||
| @mv deps dist | ||
| @cp -r lib dist/lib | ||
| @cp -r src dist/src | ||
| @cp README.md dist/README.md | ||
| @cp package.json dist/package.json | ||
| @cp binding.gyp dist/binding.gyp |
There was a problem hiding this comment.
The files key in the package.json is what controls this behavior. There is no need to build the dist folder. Went with this before because you guys seemed to like it so rode the wave but the error showed up so switched this to the canonical method of using the files key to control what gets bundled in the npm tarball
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing 4.0.0 there was an error and the bundle published without the
depsfolder. Themake commanddid not correctly switch directories and published the root folder, not thedistfolder. I updated the process to use the canonical method that node uses to avoid future issues.I also updated the supported/tested versions of node that are run in CI