Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): define NDEBUG when debug assertions are off #450

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix(rust): define NDEBUG when debug assertions are off #450

merged 1 commit into from
Jul 3, 2024

Conversation

DaniPopes
Copy link
Contributor

cc-rs does not define NDEBUG by default in release builds.

Rjected
Rjected approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jtraglia
jtraglia approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks!

@jtraglia jtraglia merged commit 1bccee0 into ethereum:main Jul 3, 2024
38 checks passed
@DaniPopes DaniPopes deleted the ndebug branch July 3, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @Rjected @jtraglia