Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java binding] Run both mainnet and minimal tests #370

Merged
merged 2 commits into from
Sep 26, 2023
Merged

[Java binding] Run both mainnet and minimal tests #370

merged 2 commits into from
Sep 26, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Sep 24, 2023 •
edited
Loading

Before running the tests in the java binding was dependent on the PRESET env value. Given it is no longer used since fieldElementsPerBlob is runtime value can run both mainnet and minimal tests in once.

  • Removed finals to make the test file consistent

jtraglia
jtraglia approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good idea! LGTM 👍

@jtraglia jtraglia merged commit eba38ea into ethereum:runtime-fields Sep 26, 2023
14 checks passed
@StefanBratanov StefanBratanov deleted the java_binding_run_mainnet_minimal branch September 26, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @jtraglia