Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force use of portable blst in Rust bindings #338

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Force use of portable blst in Rust bindings #338

merged 1 commit into from
Aug 11, 2023

Conversation

jtraglia
Copy link
Member

  • Remove features for portable and force-adx which were used by blst.
    • Leave the no-threads feature since that's still useful.
  • Remove the big match block which checks the portable and force-adx features.
  • Add non-configurable define for __BLST_PORTABLE__ when building blst.

@jtraglia
Copy link
Member Author

I'd also appreciate a review from @pawanjay176, but I can't request it for some reason.

@jtraglia jtraglia requested a review from asn-d6 August 11, 2023 14:15
asn-d6
asn-d6 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asn-d6 asn-d6 merged commit d874c06 into ethereum:main Aug 11, 2023
24 of 32 checks passed
@jtraglia jtraglia deleted the rust-portable-blst branch August 11, 2023 15:19
@belijzajac belijzajac mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn-d6 asn-d6 asn-d6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @asn-d6