Boxed blobs version 2 #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
reviewed
Aug 11, 2023
| @@ -82,6 +82,7 @@ pub fn criterion_benchmark(c: &mut Criterion) { | |||
|
|
|||
| c.bench_function("verify_kzg_proof", |b| { | |||
| b.iter(|| { | |||
| print!(""); | |||
There was a problem hiding this comment.
So this is what fixes the benchmarks 😅 we should probably add a comment here.
| assert!(matches!(error, Error::MismatchLength(_))); | ||
|
|
||
| let incorrect_blob = generate_random_blob(&mut rng); | ||
| blobs.push(incorrect_blob); | ||
|
|
||
| let blobs_copy: Vec<Blob> = blobs.iter().map(|b| *b.clone()).collect(); |
There was a problem hiding this comment.
I wish there were a way to convert from Vec<Box<Blob>> to Vec<Blob> without the blob being stored on the stack intermediately. Unfortunately, I think this is a pretty difficult to do without unsafe code.
|
This is no longer needed. The root issue was identified. Fixed here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with boxing blobs.
Should hopefully eventually resolve #331