Skip to content

Fix incorrect field name in Deneb BuilderBid type#80

Merged
ralexstokes merged 2 commits intoethereum:mainfrom
jimmygchen:fix-builder-bid-example
May 30, 2023
Merged

Fix incorrect field name in Deneb BuilderBid type#80
ralexstokes merged 2 commits intoethereum:mainfrom
jimmygchen:fix-builder-bid-example

Conversation

@jimmygchen
Copy link
Contributor

@jimmygchen jimmygchen commented May 29, 2023

I've just noticed that the field names in the BuilderBid schema doesn't match the SignedBuilderBid example JSON:

"blinded_blobs_bundle": {
"blob_roots": ["0x24564723180fcb3d994104538d351c8dcbde12d541676bb736cf678018ca4739"],
"commitments": ["0x8dab030c51e16e84be9caab84ee3d0b8bbec1db4a0e4de76439da8424d9b957370a10a78851f97e4b54d2ce1ab0d686f"],
"proofs": ["0xb4021b0de10f743893d4f71e1bf830c019e832958efd6795baf2f83b8699a9eccc5dc99015d8d4d8ec370d0cc333c06a"]
},

  • I've updated the field name to blinded_blobs_bundle to match the example. (I think this name also reflects the structure better)
  • Fixed the ordering of the fields in the example to match the schema, i.e. blob_roots comes last in blinded_blobs_bundle

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you!

@ralexstokes ralexstokes merged commit 8a090dc into ethereum:main May 30, 2023
@jimmygchen jimmygchen deleted the fix-builder-bid-example branch May 30, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants