Skip to content

Add and update types for Capella#60

Merged
ralexstokes merged 14 commits intoethereum:mainfrom
jimmygchen:capella
Feb 6, 2023
Merged

Add and update types for Capella#60
ralexstokes merged 14 commits intoethereum:mainfrom
jimmygchen:capella

Conversation

@jimmygchen
Copy link
Contributor

Builder spec changes for Capella, separated from PR #58.

Description

  • Updated ExecutionPayload & BeaconBlockBody types to align with Capella.

@jimmygchen
Copy link
Contributor Author

jimmygchen commented Jan 6, 2023

@ralexstokes @0xGabi would you mind reviewing this please? I've addressed all comments from the previous PR. This PR includes changes for Capella only.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rkapka
Copy link

rkapka commented Jan 23, 2023

We should merge this soon :-)

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice updates! I left some more comments but this is very close to merge

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice updates! I think the only thing left is to rollback the discriminator change as I think it is unnecessary given the linter update

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spectacular! thanks for all of your work here :)

@ralexstokes ralexstokes merged commit a1787c6 into ethereum:main Feb 6, 2023
@jimmygchen
Copy link
Contributor Author

spectacular! thanks for all of your work here :)

Thank you and everyone else for the review!

@metachris
Copy link
Contributor

For reference, here's the mev-boost issue to track Capella upgrades and further docs: flashbots/mev-boost#451

@metachris
Copy link
Contributor

btw, thanks again @jimmygchen - awesome work 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants