Add Builder API schema - #2
Merged
Merged
Conversation
lightclient
force-pushed
the
add-api-schema
branch
2 times, most recently
from
May 6, 2022 18:27
1fe2af9 to
079f909
Compare
ralexstokes
reviewed
May 6, 2022
ralexstokes
reviewed
May 6, 2022
ralexstokes
left a comment
ralexstokes
left a comment
Member
There was a problem hiding this comment.
looks like we lost a "status" endpoint?
ralexstokes
reviewed
May 6, 2022
ralexstokes
reviewed
May 6, 2022
ralexstokes
reviewed
May 6, 2022
ralexstokes
reviewed
May 6, 2022
ralexstokes
reviewed
May 6, 2022
ralexstokes
reviewed
May 6, 2022
Contributor
|
Live version for this spec: https://builderspec-mevboost.metachris.com/#/Builder |
metachris
reviewed
May 7, 2022
metachris
reviewed
May 7, 2022
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Chris Hager <chris@linuxuser.at>
lightclient
force-pushed
the
add-api-schema
branch
from
May 7, 2022 18:04
a84bdd8 to
9800cdb
Compare
metachris
reviewed
May 7, 2022
metachris
reviewed
May 7, 2022
tersec
reviewed
May 9, 2022
metachris
reviewed
May 9, 2022
ralexstokes
reviewed
May 9, 2022
ralexstokes
reviewed
May 9, 2022
ralexstokes
reviewed
May 9, 2022
ralexstokes
reviewed
May 9, 2022
ralexstokes
reviewed
May 9, 2022
ralexstokes
reviewed
May 9, 2022
ralexstokes
reviewed
May 9, 2022
ralexstokes
left a comment
ralexstokes
left a comment
Member
There was a problem hiding this comment.
left a few minor things to address but starting to look really good!!
ralexstokes
reviewed
May 9, 2022
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
djrtwo
reviewed
May 10, 2022
djrtwo
left a comment
djrtwo
left a comment
Collaborator
There was a problem hiding this comment.
nice! did a pass. looking good
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Member
Author
|
I really appreciate everyone's feedback. I'm going to go ahead and merge this as the feedback has slowed and things seems to be in a pretty solid place. |
This was referenced May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the schema for the Builder API.