Add getAggregatedAttestationV2 to support EIP-7549 #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
nflaig
reviewed
May 9, 2024
Contributor
|
Adding to @nflaig 's comments, if we make committee index required then this endpoint will not be backwards compatible and validator clients will have to be aware of both. |
nflaig
previously approved these changes
May 24, 2024
nflaig
reviewed
Jun 18, 2024
nflaig
approved these changes
Jun 18, 2024
nflaig
changed the title
8 tasks
rkapka
reviewed
Jun 19, 2024
rkapka
approved these changes
Jun 19, 2024
tersec
approved these changes
Jun 19, 2024
rolfyone
approved these changes
Jun 19, 2024
nflaig
reviewed
Jun 20, 2024
This was referenced Aug 10, 2024
This was referenced Dec 12, 2024
This was referenced Feb 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttestationDatapost-electra is committee-indifferent, and thus, the sameattestation_data_rootmight be shared across different committees.An aggregator is only interested in attestations in its corresponding committee.
getAggregatedAttestationV1might aggregate attestations from multiple committees sincecommittee_indexis not in its params.This PR adds
getAggregatedAttestationV2to aggregate attestations givenattestation_data_root+slot+committee_index.Part of #445