Don't produce messages for optimistic blocks - #216
Merged
Conversation
mpetrunic
reviewed
May 18, 2022
22 tasks
Contributor
|
Looks reasonable to me. Will approve when @mpetrunic gets a chance to rview your response above |
mpetrunic
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the BN does not produce attestations, aggregate attestations or sync committee contributions that refer to optimistic blocks.
Attesting to an optimistic block is very bad and could result in finalizing an invalid execution payload. The changes in this PR mean that the VC doesn't need to check the optimistic status for each object. This saves calls to the API and also protects against faults in VC implementations.
Although sync committee contributions to optimistic blocks couldn't result in an invalid finalized block, it could cause havoc for light clients.