Skip to content

add syncnets to identity metadata for altair #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpetrunic merged 4 commits into from
Jun 4, 2021
Merged

add syncnets to identity metadata for altair #150

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc00edb
add syncnets to identity metadata for altair
rolfyone Jun 2, 2021
5a3b076
fix example code
rolfyone Jun 2, 2021
2ac7339
review feedback
rolfyone Jun 4, 2021
55aae98
Merge remote-tracking branch 'upstream/master' into identity-syncnets
rolfyone Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions types/p2p.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ MetaData:
- description: "Bitvector representing the node's persistent attestation subnet subscriptions."
- $ref: "./primitive.yaml#/Hex"
- example: "0x0000000000000000"
syncnets:
allOf:
- description: "Bitvector representing the node's sync committee subnet subscriptions."

@mpetrunic mpetrunic Jun 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add notice that it will be present after altair fork is activated?

@rolfyone rolfyone Jun 4, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure of the wording, but did make an update. Happy to change it further if there's a better way of expressing it.

- $ref: "./primitive.yaml#/Hex"
- example: "0x0f"
- required: false

Peer:
type: object
Expand Down