detect folders with no tests when subfolders depth is more then 1

[winsvega]

required for #5648

[codecov-io]

Codecov Report

Merging #5661 into master will decrease coverage by 0.19%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master    #5661     +/-   ##
=========================================
- Coverage      63%   62.81%   -0.2%     
=========================================
  Files         350      349      -1     
  Lines       29905    29726    -179     
  Branches     3350     3348      -2     
=========================================
- Hits        18843    18672    -171     
+ Misses       9846     9843      -3     
+ Partials     1216     1211      -5

[gumb0]

Is it the case when -t points to a unit test?

[gumb0]

Ah no, for unit tests it should return from line 141.
When this is the case then?

[winsvega]

it is the case when you select -t TestSuite / SubTestSuite

[gumb0]

It looks like you could move this check to the outer if (line 137)
Kind of like

if (!filter.empty() && boost::filesystem::exists(m_finishedTestFoldersMap.begin()->first / filter))
{
...
}
else
{
...
}

(but check that m_finishedTestFoldersMap is not empty first)

Would it be simpler?

[gumb0]

Also maybe it would easier/more efficient to look at c_allTestNames to check whether it's single folder or subsuite, but I'm not sure

[winsvega]

if you want to call c_allTestNames more then from one place, will have to intoduce c_allTestNames.cpp