-
Notifications
You must be signed in to change notification settings - Fork 829
Add ERC: API for Hierarchical Accounts #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 21 commits
6f309c0
b22e563
c45ed58
c1f0ea1
722f1f3
bd8b633
3aeb0ca
58f2784
5f9d934
6ff4467
b5cfaf7
3d95015
4d3d641
8875ce7
3c88d35
9b2d966
6183413
dc5a0a9
bcfac6c
54ceaf4
9fec478
00bbc5b
fa70447
acf2ee2
c6f914f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,230 @@ | ||
| --- | ||
| eip: 7895 | ||
| title: API for Hierarchical Accounts | ||
| description: Adds JSON-RPC method for requesting that a universal wallet create or track another account that it owns | ||
| author: Wilson Cusack (@wilsoncusack), Jake Feldman (@jakefeldman), Montana Wong (@montycheese), Felix Zhang (@fan-zhang-sv), Jake Moxey (@jxom) | ||
| discussions-to: https://ethereum-magicians.org/t/wallet-addsubaccount/23013 | ||
| status: Draft | ||
| type: Standards Track | ||
| category: ERC | ||
| created: 2025-02-18 | ||
| --- | ||
|
|
||
| ## Abstract | ||
|
|
||
| This ERC introduces a new wallet RPC, `wallet_addSubAccount`, which allows an app to request a wallet track a smart account that the wallet owns. It also allows apps to request the wallet to provision a new account, owned by the universal wallet with a signer provided by the caller. | ||
|
|
||
|
|
||
| ## Motivation | ||
|
|
||
| Embedded app accounts (onchain accounts specific to a single app) have led to a proliferation of user addresses, which can be difficult for users to keep track of. Many embedded app account users also have a universal wallet, which can be used across apps. With hierarchical ownership–where one smart account can own another–if the embedded app account is a smart account, it could be owned by the user’s universal wallet. This would allow users to be able to control an app account via their universal wallet. However, though hierarchical ownership is already possible today, there is no way for apps to tell universal wallets about embedded app accounts a user may have. The proposed RPC provides a path for this. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should define what a "universal wallet" is. Something like MetaMask that you use cross-dapp? |
||
|
|
||
| ## Specification | ||
|
|
||
| ### Definitions | ||
| The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174. | ||
|
|
||
| Account - In this document, “account” means smart account. A smart contract that users transact from. | ||
| Sub Account - An account that SHOULD have the main account as an owner of the sub-account. For instance, Account B is a sub-account of Account A if Account A is an owner, i.e. is a signer for Account B. | ||
|
|
||
| ### JSON-RPC Methods | ||
|
|
||
| #### `wallet_addSubAccount` | ||
|
|
||
| The `wallet_addSubAccount` RPC method allows applications to request that the connected account tracks the app account, creating a hierarchy between a universal account and app-embedded accounts. This RPC supports three different use cases. | ||
jakeFeldman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ##### Request | ||
|
|
||
| ```typescript | ||
| // Previously deployed account, i.e. wallet "imports" account | ||
| type DeployedAccount = { | ||
| type: "deployed"; | ||
| // Required: address of the account | ||
| address: `0x${string}`; | ||
| keys: never; | ||
| chainId?: '0x{string}'; | ||
| factory?: never; | ||
| factoryData?: never; | ||
| } | ||
|
|
||
| // Requester is agnostic to account type and only wants to ensure its signer is an owner | ||
| type CreateAccount = { | ||
| type: "create"; | ||
| keys: { | ||
| publicKey: "0x..."; | ||
| type: "address" | "p256" | "webcrypto-p256" | "webauthn-p256"; | ||
| }[]; | ||
| } | ||
|
|
||
| // Undeployed account, app creates the account | ||
| type UndeployedAccount = { | ||
| type: "undeployed"; | ||
| address: `0x${string}`; | ||
| keys: never; | ||
| chainId?: '0x{string}'; // in Hex | ||
| // Required: factory address to create the account | ||
| factory: `0x${string}`; | ||
| // Required: factory calldata for the account | ||
| factoryData: `0x${string}`; | ||
| } | ||
|
|
||
| type Request = { | ||
| method: "wallet_addSubAccount"; | ||
| params: [{ | ||
| // JSON-RPC method version | ||
| version: string; | ||
| // JSON-RPC method account | ||
| account: CreateAccount | DeployedAccount | UndeployedAccount; | ||
| }], | ||
| } | ||
| ``` | ||
|
|
||
| ##### Response | ||
|
|
||
| Factory data and factory address are OPTIONAL and SHOULD be returned when available. Deployed accounts MAY not have these fields. | ||
|
|
||
| ```typescript | ||
| type Response = { | ||
| // Address of the account. | ||
| address: `0x${string}`; | ||
| // Optional: factory address | ||
| factory?: `0x${string}`; | ||
| // Optional: factory calldata | ||
| factoryData?: `0x${string}`; | ||
| } | ||
| ``` | ||
|
|
||
| ##### `CreateAccount` | ||
|
|
||
| Creates a new Sub Account. By default, if no signing keys (`keys`) are provided, the Sub Account's signing key MUST be created & managed by the wallet. However, an application MAY optionally provide a set of signing keys (`keys`) for the Sub Account. A wallet SHOULD make the universal account an owner of the account, creating a hierarchical relationship between the newly created account and the universal account. | ||
|
|
||
| ```typescript | ||
| type Parameters = { | ||
| address: never; | ||
| // Optional: keys of the account to be created | ||
| keys?: { | ||
| publicKey: "0x..."; | ||
| type: "address" | "p256" | "webcrypto-p256" | "webauthn-p256"; | ||
| }[]; | ||
| factory: never; | ||
| factoryData: never; | ||
| } | ||
|
|
||
| ##### UndeployedAccount | ||
|
|
||
| An undeployed account is an account that an application has created, but has not yet deployed.. The wallet can decide whether or not it is appropriate to deploy it. Wallets SHOULD validate that the universal account is an owner. Either through decoding the factoryData or simulating the deployment that there is a hierarchy between the universal account and newly created account. | ||
|
|
||
| Example: the application creates an account and generates the counterfactual address for the user to airdrop funds to. Once there is an account relationship with the universal account, the user wishes to perform a transaction, in which the wallet will deploy the account in order to execute the respective transaction. | ||
|
|
||
| ```typescript | ||
| type Parameters = { | ||
| // Required: address of the account | ||
| address: `0x${string}`; | ||
| keys: never; | ||
| factory: never; | ||
| factoryData: never; | ||
| } | ||
| ``` | ||
|
|
||
| ##### `DeployedAccount` | ||
|
|
||
| An existing account could be any smart that an app or user wants to track via their universal wallet. | ||
|
|
||
| Example: The user wants to define a hierarchical relationship between an existing app account and their universal wallet. | ||
|
|
||
| ```typescript | ||
| // Previously deployed account "import" | ||
| type Parameters = { | ||
| // Required: address of the account | ||
| address: `0x${string}`; | ||
| keys: never; | ||
| factory: never; | ||
| factoryData: never; | ||
| } | ||
| ``` | ||
|
|
||
| ### External RPC Capabilities | ||
|
|
||
| #### `wallet_connect` | ||
|
|
||
| This ERC conforms to ERC-7846 which includes [ERC-5792](./erc-5792.md) capabilities specification and introduces two new capabilities for `wallet_connect`. | ||
|
Check failure on line 150 in ERCS/erc-7895.md
|
||
|
|
||
| ##### `addSubAccount` | ||
|
|
||
| Adds a sub-account to the universal account. | ||
|
|
||
| ```typescript | ||
| type Request = { | ||
| addSubAccount: { | ||
| account: CreateAccount | DeployedAccount | UndeployedAccount; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ##### `subAccounts` | ||
|
|
||
| Fetches all sub-accounts of the universal account (including any added ones). | ||
|
|
||
| ```typescript | ||
| type Response = { | ||
| subAccounts: { | ||
| address: `0x${string}`; | ||
| factory?: `0x${string}`; | ||
| factoryData?: `0x${string}`; | ||
| }[]; | ||
| } | ||
| ``` | ||
|
|
||
| #### `wallet_getCapabilities` | ||
|
|
||
| This ERC conforms with `wallet_getCapabilities` [ERC-5792](./erc-5792.md). The response will accommodate addSubAccount support for wallets that support it. | ||
|
|
||
| ```typescript | ||
| type Response = { | ||
| addSubAccount: { | ||
| supported: true, | ||
| keyTypes: ("address" | "p256" | "webcrypto-p256" | "webauthn-p256")[]; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| // Example | ||
| const response = { | ||
| "0x2105": { | ||
| "addSubAccount": { | ||
| "supported": true, | ||
| "keyTypes": ["address", "webauthn-p256"]; | ||
| }, | ||
| }, | ||
| "0x14A34": { | ||
| "addSubAccount": { | ||
| "supported": true, | ||
| "keyTypes": ["address", "webauthn-p256"]; | ||
| }, | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## Rationale | ||
|
|
||
| ### Naming | ||
|
|
||
| Initial intent was to leverage existing RPCs, like `wallet_connect` (e.g. ERC-7846 with additional capabilities to add support for these new features, but these methods ultimately lacked flexibility. Then there were custom namespaced RPCs but this resulted with more fragmentation within the community. | ||
|
Check failure on line 212 in ERCS/erc-7895.md
|
||
|
|
||
| Method names explored `wallet_linkAccount`, `wallet_importAddress`, `wallet_addAddress`, or something else. Multiple RPCs were explored as well, separating create and tracking as two separate RPCs. To consolidate on a single RPC `wallet_addSubAccount` was selected. This method is more inclusive for EOA use cases. | ||
|
|
||
| ## Backwards Compatibility | ||
|
|
||
| This standard builds on existing JSON-RPC methods and complements [ERC-5792](./erc-5792.md) for future extensibility. Wallets can continue supporting legacy methods. | ||
|
|
||
| ## Security Considerations | ||
|
|
||
| As more capabilities are added, care should be taken to avoid unpredictable interactions. App specific accounts pose more risk for assets in those accounts. Having a universal account that maintains access to these accounts gives additional security to users and their funds. | ||
|
|
||
| ### Privacy Considerations | ||
|
|
||
| Account data and any shared capabilities must be handled securely to avoid data leaks or man-in-the-middle attacks. | ||
|
|
||
| ## Copyright | ||
|
|
||
| Copyright and related rights waived via [CC0](../LICENSE.md). | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think you need more details about what "track" means in this context. I assume that the idea is that the dapp wants a unique address, and "track" means both "display in the wallet UI" and "allow the user to send transactions from it"?