Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ERC: Human readable names for Interoperable Addresses #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add ERC: Human readable names for Interoperable Addresses #735
Changes from 9 commits
520176f
2074bbd
94a581d
7db61f0
d1eb6b8
6595ed2
9482704
ec2bd97
32b8276
5e7c7c9
d988615
680bd56
f860b00
3148986
0a1ae40
bb75a00
105cc6d
d740aa0
5a08fa5
d987f63
d542aef
471fc39
1af7ca4
dce9e3c
7725151
d8d6311
f6e7bfa
c27ef1b
6e2f92b
90a842a
46eecaf
2e193e7
37e44e0
1b68784
7c84d2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the below examples, isn't the user also just
<address> | <ens-name>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the examples below it's indeed an but if I understand correctly it could also use an
ens-subdomain
such as[email protected]
which might mean something different from[email protected]
.The former would resolve
user
locally on arbitrum, and the latter (being a fully-qualified name) would resolveuser.eth
on L1. Is that not the intention?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually opens up a very big issue that I believe it’s not discussed here: in theory,
user
should beuser
across the whole Ethereum ecosystem at least, but in fact there are many Domain Name Services beyond ENS that are local to some L2s or even just one.For example, I have jaack.eth, and also registered jaack.avax on Avalanche C-Chain and jaack.blast on Blast.
First, I believe we should consider ENS as the ‘main router’ for DNS resolutions, because it’s stated as a requirement in the ERC. Since this is the case, then resolution should be global across Ethereum, including rollups. So
user
needs to be `user.eth on any chain, especially considering that this ERC would likely be implemented around the time that Namechain will be at least on testnet, so the ENS registry is itself on a ‘service’ L2.@yoavw the case where an address is local only to its chain is the one where most addresses owned by users are smart wallets / accounts that are not the same across chains (unlike EOAs, that have the same pubkey / privkey across any EVM).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't require a new syntax: When the wallet is resolving
user.rollup.eth
, the standard resolution process should be resolve to resolve the way you described: resolverollup.eth
to get a chain identifier anduser.rollup.eth
to get an address.This approach also allows
user.rollup.eth
to override this behavior by setting a record for their own preferred chain identifier to use when their ENS name is resolved.*.rollup.eth
names will likely never override this, but I'd expect almost everyuser.eth
to want to receive funds on some chain that isn't L1.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of these fallbacks should be our target behavior. Users should be able to control on which chain assets sent to their ENS name arrive. I think ENS experts should lead the way on this resolution process via an ENSIP.