-
Notifications
You must be signed in to change notification settings - Fork 817
Update ERC-7930: Move to Last Call #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ERCS/erc-7930.md
Outdated
|
|
||
|
|
||
| ## Reference Implementation | ||
| - [Interop-SDK](https://github.com/defi-wonderland/interop-sdk/tree/dev/packages/addresses): A TypeScript/JavaScript library for encoding, decoding, and manipulating Interoperable Addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link is not within the allowed list of links, you can refer this link in discussions-to comment/section and then add the section link here
Signed-off-by: Skeletor Spaceman <[email protected]>
Signed-off-by: Skeletor Spaceman <[email protected]>
Signed-off-by: Skeletor Spaceman <[email protected]>
|
The commit 6aad265 (as a parent of d860c53) contains errors. |
@SamWilsn to see if these blocking conditions could be automated reviewed and caught by @eip-review-bot ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with our robot fren on not including the link to the reference implementation, I'd argue for removing the entire section.
Agree with all items from the review above as well, including the fact that we should move it to Review and then an editor should move it to Last Call
bumblefudge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
SamWilsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section "Version Compatibility" is written a bit weirdly. You can't really place requirements on future proposals (unless you're in a meta EIP, but that's a whole other can of worms). Instead, you should describe the behaviour of the v1 parser when it encounters, for example, a version field with the MSB set to 1.
|
|
||
|
|
||
| ## Reference Implementation | ||
| You can check the latest status on [this comment](https://ethereum-magicians.org/t/erc-7930-interoperable-addresses/23365/13). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't allow links to Ethereum Magicians except within the discussions-to header. If we did, that would allow a loophole in the immutability of a final proposal.
| status: Last Call | ||
| last-call-deadline: 2025-10-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| status: Last Call | |
| last-call-deadline: 2025-10-20 | |
| status: Review |
Move EIP-7930 to Last Call, with deadline 14 days from now: 2025-10-20.