Skip to content

Conversation

@euler0x
Copy link
Contributor

@euler0x euler0x commented Oct 6, 2025

Move EIP-7930 to Last Call, with deadline 14 days from now: 2025-10-20.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 6, 2025

File ERCS/erc-7930.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Update EIP-7930: Move to Last Call Update ERC-7930: Move to Last Call Oct 6, 2025
@github-actions github-actions bot added the w-ci label Oct 6, 2025
@github-actions github-actions bot removed the w-ci label Oct 6, 2025
@github-actions github-actions bot added the w-ci label Oct 6, 2025
ERCS/erc-7930.md Outdated


## Reference Implementation
- [Interop-SDK](https://github.com/defi-wonderland/interop-sdk/tree/dev/packages/addresses): A TypeScript/JavaScript library for encoding, decoding, and manipulating Interoperable Addresses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is not within the allowed list of links, you can refer this link in discussions-to comment/section and then add the section link here

@github-actions github-actions bot added w-ci and removed w-ci labels Oct 10, 2025
Signed-off-by: Skeletor Spaceman <[email protected]>
@github-actions
Copy link

The commit 6aad265 (as a parent of d860c53) contains errors.
Please inspect the Run Summary for details.

@xinbenlv
Copy link
Collaborator

xinbenlv commented Oct 14, 2025

  1. Proposer is not one of the authors
  2. A status change PR should be separate from content change PR
  3. It should move from Draft to Review first and then Review to Last Call. Any other requests are exceptional and should only be granted by exceptional consensus of EIP Editors such as "Call for Input" etc.

@SamWilsn to see if these blocking conditions could be automated reviewed and caught by @eip-review-bot ?

Copy link
Contributor

@0xteddybear 0xteddybear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with our robot fren on not including the link to the reference implementation, I'd argue for removing the entire section.
Agree with all items from the review above as well, including the fact that we should move it to Review and then an editor should move it to Last Call

Copy link

@bumblefudge bumblefudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section "Version Compatibility" is written a bit weirdly. You can't really place requirements on future proposals (unless you're in a meta EIP, but that's a whole other can of worms). Instead, you should describe the behaviour of the v1 parser when it encounters, for example, a version field with the MSB set to 1.



## Reference Implementation
You can check the latest status on [this comment](https://ethereum-magicians.org/t/erc-7930-interoperable-addresses/23365/13).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't allow links to Ethereum Magicians except within the discussions-to header. If we did, that would allow a loophole in the immutability of a final proposal.

Comment on lines +7 to +8
status: Last Call
last-call-deadline: 2025-10-20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status: Last Call
last-call-deadline: 2025-10-20
status: Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants