Update ERC-7943: Split into separate interfaces#1210
Merged
eip-review-bot merged 4 commits intoethereum:masterfrom Sep 22, 2025
Merged
Update ERC-7943: Split into separate interfaces#1210eip-review-bot merged 4 commits intoethereum:masterfrom
eip-review-bot merged 4 commits intoethereum:masterfrom
Conversation
Collaborator
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
eip-review-bot
previously approved these changes
Sep 12, 2025
Collaborator
eip-review-bot
left a comment
eip-review-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
xaler5
changed the title
auto-merge was automatically disabled
September 12, 2025 08:06
Pull request was converted to draft
eip-review-bot
previously approved these changes
Sep 22, 2025
Collaborator
eip-review-bot
left a comment
eip-review-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
auto-merge was automatically disabled
September 22, 2025 11:20
Head branch was pushed to by a user without write access
eip-review-bot
approved these changes
Sep 22, 2025
Collaborator
eip-review-bot
left a comment
eip-review-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
eip-review-bot
approved these changes
Sep 22, 2025
Collaborator
eip-review-bot
left a comment
eip-review-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canTransfershould returnfalseon paused contracts.canTransferperformingisUserAllowedwith ERC-3643.Things to review:
getFrozenTokensfor ERC-721 should return uint256 or a bool ?