Skip to content

Add ERC: Minimal Avatar Smart Wallet (MASW) #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 21, 2025
Merged

Add ERC: Minimal Avatar Smart Wallet (MASW) #1118

merged 13 commits into from
Nov 21, 2025

Conversation

@MostafaS
Copy link
Contributor

@MostafaS MostafaS commented Jul 9, 2025

What

Adds a new ERC draft defining the Minimal Avatar Smart Wallet (MASW), a delegate‑wallet for EIP‑7702.

Files added

  • ERCS/eip-0.md
  • assets/eip-0/MASW.sol

Discussion

https://ethereum-magicians.org/t/erc-tbd-minimal-avatar-smart-wallet-masw-delegate-wallet-for-eip-7702/24761

Reference implementation

Relative link: MASW.sol

Checklist

  • Passes eipw
  • Uses CC0 licence line
  • Author field includes my GitHub handle

@MostafaS MostafaS requested a review from eip-review-bot as a code owner July 9, 2025 07:04
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jul 9, 2025 •
edited
Loading

✅ All reviewers have approved.

@github-actions github-actions bot added the w-ci label Jul 9, 2025
@eip-review-bot eip-review-bot changed the title ERC‑TBD: Minimal Avatar Smart Wallet (MASW) Add ERC: Minimal Avatar Smart Wallet (MASW) Jul 9, 2025
@github-actions github-actions bot added w-ci and removed w-ci labels Jul 9, 2025
@github-actions
Copy link

github-actions bot commented Jul 13, 2025

The commit 44eae39 (as a parent of 684f50f) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Jul 13, 2025
@poojaranjan poojaranjan mentioned this pull request Jul 28, 2025
Closed
bomanaps
bomanaps reviewed Jul 29, 2025
View reviewed changes
@poojaranjan poojaranjan mentioned this pull request Aug 5, 2025
Closed
3 tasks
@MostafaS
Copy link
Contributor Author

MostafaS commented Aug 19, 2025

Hi @g11tech @SamWilsn @xinbenlv
I've fixed the CI issues and addressed Magicians feedback on compatibility. Ready for review? Happy to make changes.

SamWilsn
SamWilsn reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just to confirm, the idea is that anyone can implement their own MASW and deploy it, and because all MASW implementations share the same interface, the off-chain part of wallets can interop smoothly?

@MostafaS
Copy link
Contributor Author

MostafaS commented Aug 23, 2025

So just to confirm, the idea is that anyone can implement their own MASW and deploy it, and because all MASW implementations share the same interface, the off-chain part of wallets can interop smoothly?

Hi, yes, exactly. As long as the chain the wallet interacts with supports post-pectra changes (eip-7702) , the wallet interactions will be smooth.

@MostafaS MostafaS requested a review from SamWilsn August 23, 2025 10:01
@poojaranjan poojaranjan mentioned this pull request Sep 23, 2025
Closed
3 tasks
This was referenced Oct 14, 2025
Closed
Closed
@MostafaS MostafaS closed this Oct 23, 2025
@MostafaS MostafaS reopened this Oct 23, 2025
@MostafaS
Copy link
Contributor Author

MostafaS commented Oct 27, 2025

Hi @SamWilsn @xinbenlv @g11tech,

This PR has been ready for review for a while now. The Auto Review Bot is requesting an approval from one of you to move forward.

@SamWilsn - thank you for your earlier feedback in August! I addressed all your comments. Would you be able to give this an official approval review?

I'd really appreciate any feedback or approval so we can move this ERC forward.

Thank you!

SamWilsn
SamWilsn reviewed Nov 21, 2025
View reviewed changes
msadjadi-ops and others added 13 commits November 21, 2025 12:50
@msadjadi-ops @SamWilsn
ERC: Minimal Avatar Smart Wallet (MASW)
41fac27
@msadjadi-ops @SamWilsn
Lint: restore eip filename, remove requires, fix dashes
01fb4e3
@your @SamWilsn
Fix EIPW lint: filename, links, ASCII dashes
aa05e66
@your @SamWilsn
updated the file to fix the naming
0a50a62
@your @SamWilsn
Rename eip-0.md → erc-0.md to satisfy eipw rule
10286e8
@SamWilsn
Update and rename erc-0.md to erc-7988.md
11c990e
@SamWilsn
Rename MASW.sol to MASW.sol
b41c154
@MostafaS @SamWilsn
Fix asset directory naming and link reference
24ef104 
- Rename assets/eip-7988/ to assets/erc-7988/ to match ERC convention
- Update link in ERC-7988.md from ../assets/eip-0/MASW.sol to ../assets/erc-7988/MASW.sol
- This should resolve the HTMLProofer CI failure
@MostafaS @SamWilsn
Update ERC-7988 and MASW.sol implementation
75baec4
@MostafaS @SamWilsn
Fix internal linking in ERC-7988
1ff8a5d
@MostafaS @SamWilsn
Update ERCS/erc-7988.md
ae1103b 
Co-authored-by: Sam Wilson <[email protected]>
@MostafaS @SamWilsn
replaced the lowercase "may" and "must" mentions to uppercase.
1c421b1
@SamWilsn
Apply suggestions from code review
c57ada0
@eip-review-bot eip-review-bot enabled auto-merge (squash) November 21, 2025 17:51
eip-review-bot
eip-review-bot approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 0119363 into ethereum:master Nov 21, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@eip-review-bot eip-review-bot eip-review-bot approved these changes

+1 more reviewer

@bomanaps bomanaps bomanaps left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c-new e-consensus e-review s-draft t-erc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MostafaS @eip-review-bot @SamWilsn @bomanaps @msadjadi-ops @your