-
Notifications
You must be signed in to change notification settings - Fork 829
Add ERC: DomainKeys Identified Mail (DKIM) Registry #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All reviewers have approved. |
ERCS/erc-7969.md
Outdated
| title: DKIM Registry Interface | ||
| description: An interface for registering and validating DKIM public key hashes onchain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably omit "Interface" from your title, since they're pretty common in ERCs, and use the space to add more detail about the proposal. Maybe something like "DKIM Registry for ..." and add the main use case?
The description needs a bit more work. You should probably explain what DKIM is, or how putting it on chain is beneficial, or really anything more than just repeating your title but with more words.
ERCS/erc-7969.md
Outdated
| ### Interface | ||
|
|
||
| ```solidity | ||
| // SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code within the document itself must be CC0-1.0 licensed. We do permit MIT code in the assets/ directory and you can link to it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment. I directly removed the license as other ERCs usually don't have it as well.
ERCS/erc-7969.md
Outdated
| ## Reference Implementation | ||
|
|
||
| ```solidity | ||
| // SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same CC0-1.0 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment. I directly removed the license as other ERCs usually don't have it as well.
f0d60b7 to
48cc7d5
Compare
45676b5 to
cbbb5ce
Compare
cbbb5ce to
c00423f
Compare
|
The commit c00423f (as a parent of 50b2ea3) contains errors. |
7ee6b0b to
9fda6c7
Compare
- Change description from "A standard interface" to "An interface" - Add link to ERC-4337 in motivation section
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Ernesto García <[email protected]>
9fda6c7 to
b618955
Compare
b618955 to
1174d52
Compare
eip-review-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Introduces a standard interface for registering and validating DKIM public key hashes on-chain.
This ERC enables email-based account abstraction and recovery by allowing domain owners to register their DKIM keys in a decentralized registry. Key features include domain hash validation, key hash registration/revocation events, and compatibility with ZK Email technology and ERC-4337. The interface provides a crucial building block for trustless email ownership verification, enabling users to create smart contract wallets and implement social recovery mechanisms using email credentials.