Skip to content

Conversation

@moodysalem
Copy link
Contributor

@moodysalem moodysalem commented May 14, 2025

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented May 14, 2025

✅ All reviewers have approved.

@github-actions github-actions bot removed the w-ci label May 20, 2025
@eip-review-bot eip-review-bot changed the title add uwulink ERC Add ERC: Unidirectional Wallet Uplink aka UWULink May 20, 2025
@github-actions github-actions bot added the w-ci label May 20, 2025
ERCS/erc-7946.md Outdated
dApps often require users to perform multistep interactions, such as approving a token and then executing a
swap. Traditionally, accomplishing this has required multiple user confirmations or complex wallet connectivity.
Recent standards like EIP-5792 and EIP-7702 introduced ways to batch multiple calls into one atomic operation via
JSON-RPC (e.g. `wallet_sendCalls`). However, those solutions assume an active connection

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sendCalls does not require a from address and no prior connection is required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To what interface would you send the wallet_sendCalls RPC? In practice you connect a wallet first, check capabilities, and use wallet_sendCalls only if it's available. It seems like connecting a wallet is a prerequisite to know where to send the RPC.

This would be very different from the dApp having all actions available in the unconnected state, and when you trigger an action (e.g. a swap) it could pop up a modal with the QR code to perform the action, and/or a link with the uwulink scheme, a la magnet link, that triggers the transaction for any extension that registered itself to handle the scheme

@github-actions
Copy link

The commit 0da12b9 (as a parent of 01fd850) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Jun 19, 2025
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reasonably happy with this proposal's formatting so far. The only outstanding issues is the protocol buffers reference. You can't exactly implement this proposal without understanding protobufs, but referring to its standard is likely to be contentious among editors.

@moodysalem
Copy link
Contributor Author

I'm reasonably happy with this proposal's formatting so far. The only outstanding issues is the protocol buffers reference. You can't exactly implement this proposal without understanding protobufs, but referring to its standard is likely to be contentious among editors.

Thank you for fixing the errors! I was a bit stumped on that.

What makes protobuf different than JSON + a JSON schema that it would need to be referenced?

@SamWilsn
Copy link
Contributor

JSON is defined in RFC 8259 and JSON Schema isn't strictly required to build a compatible implementation. I do see your point though.

I'll see if we can allow Protobufs.

@eip-review-bot eip-review-bot enabled auto-merge (squash) August 22, 2025 17:26
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 0c41842 into ethereum:master Aug 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants